Skip to content

Conversation

@boazpoolman
Copy link
Member

…read-only API token

What does it do?

It renames the router controller from 'router' to 'find'. I've added backwards compatibility for anybody using the controller on their own custom endpoint. This will be removed in the next major version.

Why is it needed?

To make the endpoint accessible when using a read-only API token.

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

#309 #7

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2025

🦋 Changeset detected

Latest commit: 2fd0445

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
strapi-plugin-webtools Major
webtools-addon-sitemap Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@boazpoolman
Copy link
Member Author

This actually seems to be a breaking change. I didn't realize that permissions are given to the controller, not the route. So renaming the controller will reset existing permissions. This will need a major version bump and will for that reason be postponed.

@boazpoolman boazpoolman force-pushed the feature/fix-api-token-access branch from 427746d to 2fd0445 Compare October 20, 2025 19:57
@boazpoolman boazpoolman marked this pull request as draft October 20, 2025 19:58
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.89%. Comparing base (0625149) to head (2fd0445).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #338   +/-   ##
=======================================
  Coverage   38.89%   38.89%           
=======================================
  Files           2        2           
  Lines         653      653           
  Branches      163      163           
=======================================
  Hits          254      254           
  Misses        317      317           
  Partials       82       82           
Flag Coverage Δ
unit 38.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants