Skip to content

Fix injection of not null fields #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix injection of not null fields #542

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6480e68
add nullable fields on function
Mary-Clb Oct 31, 2025
6ab35aa
fix isNullable list
Mary-Clb Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion inc/userinjection.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,14 @@ public function connectedTo()

public function isNullable($field)
{
return true; // By default, all fields can be null
return in_array($field, [
Copy link
Contributor

@Rom1-B Rom1-B Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the user, that's a long list. Wouldn't it be easier to manage an exclusion list?

In any case, it needs to be sorted alphabetically, which will make it easier to maintain.

Copy link
Contributor Author

@Mary-Clb Mary-Clb Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it that way to respect the code already written in this PR :

https://github.com/pluginsGLPI/datainjection/pull/502/files#diff-ed87f9bda1f73e2d962ded1532617a242b44027fa95b5cef2f03012ff3432eba

as there was already an example in this file :

https://github.com/pluginsGLPI/datainjection/pull/502/files#diff-91a615ac23201a0394dd8c6b70359227cc7799abeedb7822463b3d46b8a9822c

Copy link
Contributor

@Rom1-B Rom1-B Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your example only has 15 columns, so you can easily display everything on one screen without scrolling, which is not the case here.

For consistency, you can reorder the other case as well.

Copy link
Contributor

@Lainow Lainow Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After running a few tests, only these fields need to be added to the list. The others do not return any errors, so I don't think it's necessary to add them.

public function isNullable($field)
    {
        return in_array($field, [
            'begin_date',
            'date_sync',
            'end_date',
            'last_login',
            'substitution_end_date',
            'substitution_start_date',
        ]);
    }

'begin_date',
'date_sync',
'end_date',
'last_login',
'substitution_end_date',
'substitution_start_date',
]);
}


Expand Down