Skip to content

GLPI 11 compatibility #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

GLPI 11 compatibility #285

wants to merge 9 commits into from

Conversation

Lainow
Copy link
Contributor

@Lainow Lainow commented Jan 30, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes # (issue number, if applicable)
  • Here is a brief description of what this PR does
    GLPI 11 compatibility management and redesign of the TWIG configuration page.

Before
escalade10

After
escalade11

Screenshots (if appropriate):

@Lainow Lainow self-assigned this Jan 30, 2025
@Lainow Lainow requested review from Rom1-B and stonebuzz January 30, 2025 10:44
stonebuzz
stonebuzz approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@stonebuzz stonebuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok

Rom1-B
Rom1-B requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests also fail

@Lainow Lainow requested a review from Rom1-B February 12, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonebuzz stonebuzz stonebuzz approved these changes

@Rom1-B Rom1-B Awaiting requested review from Rom1-B

Requested changes must be addressed to merge this pull request.

Assignees

@Lainow Lainow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lainow @stonebuzz @Rom1-B