22 #64
22 #64
Conversation
this. @Divide-By-0 any comments while I didn't start to apply it more widely?
[discussion]: 251fba6#commitcomment-130400727 @Divide-By-0 : just to let to have one more look at the thing while I continue.
This reverts commit 58fa946.
Fun fact: I already was confused by that "hash2" naming, lol. [discussion]: 251fba6#commitcomment-130400727 @Divide-By-0 : just to let to have one more look at the thing while I continue.
|
I should notice another mildly confusing naming: |
|
No one's using tests yet, feel free to edit those. S isn't ideal I agree, open to anything else. |
@Divide-By-0 , I guess it's better to give a look to this one particular commit; I mean Circom code first of all ofc. Tomorrow will be squashing, and filling PR.
|
For circom, the code is way cleaner if you do this: #48 Can you merge in that PR first, compile the circuits to make sure they work? It will make circom easier to read and maintain. |
Ok, am running test suite rn. Merging amount is unexpected. 🤯 |
I meant that I think it's actually good to preserve reasonable cognitive load in tests. I updated parts which were too confusing; though they're relatively rough and unpolished for good. I'll think further about "S" though you can see absence of suggestions on my side. X) |
|
To be merged via #66 due to merging conflict. |
tests weren't touched on purpose to raise additional awareness of those who will be modifying them to recheck implementations against each other