feat(cube): add aws s3 bucket #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walkoss
requested review from
michaeljguarino,
davidspek and
rauerhans
as code owners
This reverts commit 203bd85.
cube/plural/recipes/cube-aws.yaml
Outdated
| @@ -13,6 +13,10 @@ sections: | |||
| - name: hostname | |||
| type: DOMAIN | |||
| documentation: the fully qualified domain name your cube api will be available at | |||
| - name: cubeBucket | |||
| type: BUCKET | |||
| documentation: gcs bucket for storing cube files | |||
There was a problem hiding this comment.
gcs bucket -> s3 bucket
cube/terraform/aws/iam.tf
Outdated
| oidc_fully_qualified_subjects = ["system:serviceaccount:${var.namespace}:${var.cube_serviceaccount}"] | ||
| } | ||
|
|
||
| resource "aws_iam_user" "cube" { |
There was a problem hiding this comment.
I believe this iam user is no longer needed
michaeljguarino
approved these changes
Jul 26, 2023
michaeljguarino
requested changes
Jul 26, 2023
michaeljguarino
approved these changes
Jul 27, 2023
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Checklist
plural from-grafanato convert a grafana dashboard found via google to our CRDpluralsh/module-libraryto accelerate this