Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Docker capi cluster #858

Merged
merged 2 commits into from
Sep 29, 2023
Merged

fix: Docker capi cluster #858

merged 2 commits into from
Sep 29, 2023

Conversation

zreigz
Copy link
Member

@zreigz zreigz commented Sep 29, 2023

Summary

this PR fixes docker CAPI cluster deployment

Test Plan

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

@zreigz zreigz changed the title Docker capi cluster fix: Docker capi cluster Sep 29, 2023
davidspek
davidspek approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@davidspek davidspek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidspek davidspek merged commit 7982966 into main Sep 29, 2023
5 of 7 checks passed
@davidspek davidspek deleted the docker-capi-cluster branch September 29, 2023 10:13
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.14.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidspek davidspek davidspek approved these changes

@michaeljguarino michaeljguarino Awaiting requested review from michaeljguarino michaeljguarino is a code owner

@rauerhans rauerhans Awaiting requested review from rauerhans

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zreigz @plural-bot @davidspek