-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade ray -> 2.7 #863
Conversation
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
feat(ray): update chart and image
Potential issues after more stringent testing resolved |
@@ -3,8 +3,8 @@ name: kuberay-operator | |||
description: A Helm chart for Kubernetes | |||
type: application | |||
version: 0.1.3 | |||
appVersion: "v0.3.0" | |||
appVersion: "v0.6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appVersion here should be v2.7.0
(the version of ray itself)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in ray/helm/ray/Chart.yaml
i have the appVersion set to 2.7.0
. since this chart.yaml is for kuberay i put the kuberay operator version, i can switch this to 2.7.0
but just want to double check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh i didn't realize, that's probably fine.
ray/helm/kuberay-operator/Chart.yaml
Outdated
@@ -3,8 +3,8 @@ name: kuberay-operator | |||
description: A Helm chart for Kubernetes | |||
type: application | |||
version: 0.1.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'll need to bump this as well
hey @troyyyang is there a reason this is still a draft PR? Let us know when it's ready to test on our end and we can get it merged. |
let me know what i should do with the appversion, but otherwise all set |
@@ -3,8 +3,8 @@ name: kuberay-operator | |||
description: A Helm chart for Kubernetes | |||
type: application | |||
version: 0.1.3 | |||
appVersion: "v0.3.0" | |||
appVersion: "v0.6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh i didn't realize, that's probably fine.
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
was testing #713 which upgrades to 2.5. for some reason the head node was constantly restarting. i pulled the branch in my fork and bumped it to 2.7 and tested in an aws cluster. head node is stable, and ran some cursory tests that all worked.
Test Plan
tested on aws cluster
Checklist
plural from-grafana
to convert a grafana dashboard found via google to our CRDpluralsh/module-library
to accelerate this