Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove enable OIDC issuer bootstrap step and set ASO-related flags #456

Merged
merged 7 commits into from
Oct 11, 2023
Merged

feat: Remove enable OIDC issuer bootstrap step and set ASO-related flags #456

merged 7 commits into from
Oct 11, 2023

Conversation

maciaszczykm
Copy link
Member

Summary

Remove enable OIDC issuer bootstrap step as it will be handled by CAPZ once pluralsh/plural-artifacts#852 will be merged.

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@maciaszczykm maciaszczykm mentioned this pull request Sep 27, 2023
Merged
25 tasks
@maciaszczykm maciaszczykm added the enhancement New feature or request label Sep 28, 2023
@maciaszczykm maciaszczykm changed the title feat: Remove enable OIDC issuer bootstrap step feat: Remove enable OIDC issuer bootstrap step and set bootstrapMode flags Oct 4, 2023
@maciaszczykm maciaszczykm changed the title feat: Remove enable OIDC issuer bootstrap step and set bootstrapMode flags feat: Remove enable OIDC issuer bootstrap step and set ASO-related flags Oct 5, 2023
davidspek
davidspek approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@davidspek davidspek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciaszczykm maciaszczykm merged commit b5649c1 into main Oct 11, 2023
9 of 11 checks passed
@maciaszczykm maciaszczykm deleted the marcin/az-oidc-issuer branch October 11, 2023 08:32
@maciaszczykm maciaszczykm restored the marcin/az-oidc-issuer branch October 11, 2023 08:32
@maciaszczykm maciaszczykm deleted the marcin/az-oidc-issuer branch October 11, 2023 08:32
@maciaszczykm maciaszczykm restored the marcin/az-oidc-issuer branch October 11, 2023 08:32
@maciaszczykm maciaszczykm deleted the marcin/az-oidc-issuer branch October 11, 2023 08:32
michaeljguarino pushed a commit that referenced this pull request Aug 28, 2024
@maciaszczykm @michaeljguarino
feat: Remove enable OIDC issuer bootstrap step and set ASO-related fl…
5b138a2 
…ags (#456)

* remove enable OIDC issuer bootstrap step

* fix linter issues

* update bootstrapMode flags

* update asoControllerSettings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidspek davidspek davidspek approved these changes

@michaeljguarino michaeljguarino Awaiting requested review from michaeljguarino michaeljguarino is a code owner

@zreigz zreigz Awaiting requested review from zreigz zreigz is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciaszczykm @davidspek