HTTP client abstraction layer with BaseHttpClient ABC #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces infrastructure/http module with: - BaseHttpClient ABC defining the client contract (open/close/closed/get) - Factory functions for SSL context and secure connector creation - AiohttpClient implementation with flexible configuration options - Support for both context manager and manual lifecycle management Refactors exception hierarchy: - Add RheoError as top-level base for all library exceptions - Add InfrastructureError -> HttpClientError -> ClientNotInitialisedError - DownloadManagerError now inherits from RheoError
Replaces inline SSL context and connector creation with AiohttpClient. Manager now accepts BaseHttpClient, enabling future client swapping. Only calls open() on clients it owns, preserving injected client behaviour.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
plutopulp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces an HTTP client abstraction layer to decouple the download infrastructure from aiohttp specifics, improving testability and enabling future client implementations.
Key changes:
Benefits: