Add cancellation foundation: enums, stats, and enriched event #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces two new enums in rheo.domain.cancellation: - CancelResult: explicit return type for cancel operations - CancelledFrom: indicates download state when cancelled These provide clear semantics for the upcoming cancel() implementation.
Adds cancelled count to DownloadStats and updates tracker.get_stats() to populate it. This allows users to see how many downloads were cancelled via manager.stats.cancelled.
Updates DownloadCancelledEvent to include: - cancelled_from: CancelledFrom enum indicating if download was QUEUED or IN_PROGRESS This allows subscribers to distinguish between cancelling queued vs active downloads.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lays the groundwork for selective download cancellation. Adds domain types, observability, and event enrichment without behavioural changes.
Changes
Domain
CancelResultenum: explicit return type for upcomingcancel()method (CANCELLED,NOT_FOUND,ALREADY_TERMINAL)CancelledFromenum: distinguishes cancellation of queued vs in-progress downloadsObservability
cancelledfield toDownloadStatsfor tracking cancelled download countEvents
DownloadCancelledEventwith requiredcancelled_fromfieldcancelled_from=IN_PROGRESSon task cancellationContext
This prepares the selective download cancellation feature. Next PR will add the actual
manager.cancel(download_id)method using these foundations.