-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vectorized block diagonal mat inversion #1092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Control question: You have verified that the inverted matrices are correct?
Given the performance results, I think we should make this into the default inverter. This will require changing parameter values in mpfa, mpsa and biot. A repository-wide search for 'inverter' may be needed.
Proposed changes
This PR refactor and introduce a vectorized solution for the function
invert_diagonal_blocks_python
in filematrix_operations.py
. The function is 2x faster than numba function for a large block diagonal matrix with irregular block sizes.Types of changes
What types of changes does this PR introduce to PorePy?
Put an
x
in the boxes that apply.Checklist
Put an
x
in the boxes that apply or explain briefly why the box is not relevant.pytest
was run with the--run-skipped
flag.