Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split equation system assemble method #1094

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

IvarStefansson
Copy link
Contributor

Proposed changes

  1. Deletes redundant assemble_subsystem method from EquationSystem. Same functionality is now covered by assemble.
  2. Add evaluate_jacobian parameter to assemble.
  3. Resurrect test_equation_system, which was deleted by mistake.

Types of changes

What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply.

  • Minor change (e.g., dependency bumps, broken links).
  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Testing (contribution related to testing of existing or new functionality).
  • Documentation (contribution related to adding, improving, or fixing documentation).
  • Maintenance (e.g., improve logic and performance, remove obsolete code).
  • Other:

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

  • The documentation is up-to-date.
  • Static typing is included in the update.
  • This PR does not duplicate existing functionality.
  • The update is covered by the test suite (including tests added in the PR).
  • If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

@IvarStefansson
Copy link
Contributor Author

@keileg, could you please have an initial look.

Copy link
Contributor

@keileg keileg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a few minor changes, including one which should take care of the remaining typing issue.

I have no further comments, so if you are happy with my changes, I can do a quick formal review before we do the merge.

@keileg keileg marked this pull request as ready for review January 12, 2024 13:24
@keileg keileg requested a review from OmarDuran as a code owner January 12, 2024 13:24
@keileg keileg merged commit f2a532f into develop Jan 12, 2024
4 checks passed
@keileg keileg deleted the split-EquationSystem-assemble-method branch January 12, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants