Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Cartesian grid and MandelSetup #1308

Merged

Conversation

IngridKJ
Copy link
Contributor

Proposed changes

Addresses issue #1137. The issue reports a possible functional error in mandels_problem.py. The only problem @IvarStefansson and I found while trying to reproduce the issue was some division by zero while plotting (if Cartesian grids were used). A user warning is now implemented and the problematic plotting is skipped in the case of Mandel's problem being run with a Cartesian grid. Please refer to the issue for more detailed breakdown of the problem.

Types of changes

What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply.

  • Minor change (e.g., dependency bumps, broken links).
  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Testing (contribution related to testing of existing or new functionality).
  • Documentation (contribution related to adding, improving, or fixing documentation).
  • Maintenance (e.g., improve logic and performance, remove obsolete code).
  • Other:

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

  • The documentation is up-to-date.
  • Static typing is included in the update.
  • This PR does not duplicate existing functionality.
  • The update is covered by the test suite (including tests added in the PR).
  • If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

@keileg keileg self-assigned this Jan 20, 2025
Copy link
Contributor

@keileg keileg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a fair solution. Though I have the feeling we will return to the (suspected) issue with Mpsa at some future point, temporary closure seems like the right thing to do.

@IngridKJ IngridKJ merged commit 80c6aa6 into develop Jan 20, 2025
5 checks passed
@IngridKJ IngridKJ deleted the 1137-functional-error-identified-in-file-mandels_problemipynb branch January 20, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functional error identified in file mandels_problem.ipynb
2 participants