Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python 3.13 #1313

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Upgrade to Python 3.13 #1313

merged 4 commits into from
Jan 24, 2025

Conversation

keileg
Copy link
Contributor

@keileg keileg commented Jan 23, 2025

Proposed changes

For now (and likely until the end of April), we will support Python 3.11-3.13.

Changes included:

  1. All GH actions run on 3.13.
  2. The base docker image is based on Python 3.13

This PR should not be merged until:

  1. The GH action running all tests run successfully. EDIT: OK
  2. The Docker build on Python 3.13 has been verified to work. EDIT: OK

Types of changes

What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply.

  • Minor change (e.g., dependency bumps, broken links).
  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Testing (contribution related to testing of existing or new functionality).
  • Documentation (contribution related to adding, improving, or fixing documentation).
  • Maintenance (e.g., improve logic and performance, remove obsolete code).
  • Other: Build system

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

  • The documentation is up-to-date.
  • Static typing is included in the update.
  • This PR does not duplicate existing functionality.
  • The update is covered by the test suite (including tests added in the PR).
  • If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

@keileg
Copy link
Contributor Author

keileg commented Jan 23, 2025

Tests run on 3.13 will be made required once this PR is working.

@keileg
Copy link
Contributor Author

keileg commented Jan 24, 2025

@IvarStefansson @jwboth: Slow tests and the Docker build were both successful, so we should be all set.

I have changed the branch protection rule to require tests to be run on Python 3.13 to make this PR pass. As a byproduct, that means that no other PRs can be merged before this one. Sorry if that comes across as extorsion.

@jwboth
Copy link
Contributor

jwboth commented Jan 24, 2025

Looks good!

@IvarStefansson IvarStefansson merged commit 4cae1e4 into develop Jan 24, 2025
6 checks passed
@IvarStefansson IvarStefansson deleted the python_313 branch January 24, 2025 14:56
@keileg keileg mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants