Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix keep-output command line argument in profiling script #1315

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

pschultzendorff
Copy link
Contributor

Proposed changes

The argparse argument --keep_output in the profiler was initiated with action="store_true" and default=True. This meant it couldn't be set to False. I changed the argument to --clear_output with action="store_true", which is automatically initiated with default=False. Everything stays the same, except one can now actually use the flag.

Types of changes

  • Minor change (e.g., dependency bumps, broken links).
  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Testing (contribution related to testing of existing or new functionality).
  • Documentation (contribution related to adding, improving, or fixing documentation).
  • Maintenance (e.g., improve logic and performance, remove obsolete code).
  • Other:

Checklist

  • The documentation is up-to-date.
  • Static typing is included in the update.
  • This PR does not duplicate existing functionality.
  • The update is covered by the test suite (including tests added in the PR).
  • If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

@pschultzendorff pschultzendorff merged commit 1345c48 into develop Jan 28, 2025
6 checks passed
@pschultzendorff pschultzendorff deleted the fix_profiling branch January 28, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants