-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Ruff formatting and linting. Install configuration moved to pyproject.toml #1323
Conversation
They can be standard strings
Also updated the install instruction after the move to pyproject.toml
With pyproject.toml instead of requiremnets, the install is changed somewhat.
These are superseeded by pyproject.toml
Typo in last commit
Toml must be available.
No idea what the issue really is.
@jwboth @IvarStefansson: Tests are finally passing, this should be ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. Am I right ruff is somewhat stricter on blank lines than black?
That could be, I have honestly not looked at the detailed reformatting. Life got easier when I outsourced all thinking about formatting to black, and that is a habit that is hard to break. |
Co-authored-by: Ivar Stefansson <ivar.stefansson@uib.no>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through the changes, and have no objections. Ruff looks good to me.
Proposed changes
This PR suggests two changes to how the PorePy project is installed and managed:
setup.py,
setup.cfg
andrequirements.txt
topyproject.toml
. While this is not an urgent update, it has been the recommended way of managing python projects for some years now.setup.py
) in this PR are due to this change, with formatting being the main culprit. UPDATE: Mypy forced a few additional updates, but ruff formatting is still by far the main contributor.Both these updates necessitated updates to the GH action files as well.
@IvarStefansson @jwboth Can you please have a look at the changes and let me know what you think? But do so after the tests have passed; I cannot I did not introduce bugs in GH action setups.
Types of changes
What types of changes does this PR introduce to PorePy?
Put an
x
in the boxes that apply.Checklist
Put an
x
in the boxes that apply or explain briefly why the box is not relevant.pytest
was run with the--run-skipped
flag.