-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scipy requirement from <=1.10 to <=1.11.1 #932
Conversation
Updates the requirements on [scipy](https://github.com/scipy/scipy) to permit the latest version. - [Release notes](https://github.com/scipy/scipy/releases) - [Commits](scipy/scipy@v0.1.0...v1.11.1) --- updated-dependencies: - dependency-name: scipy dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
This is connected with some possibly deep changes in scipy's sparse data formats. We should not upgrade before having explored the consequences. |
Having looked at this in some more detail, it seems to me that Scipy's new array format is not yet a drop-in replacement for the old matrix classes. For instance, slicing operations are for the moment not fully implemented, see https://docs.scipy.org/doc/scipy/reference/sparse.html#module-scipy.sparse. My suggestion is:
@IvarStefansson, @OmarDuran: Does this make sense to you? |
Yes, I think so. But I'm not overly confident in my opinion, not having looked into this. |
I completely agree with both suggestions. In the case of updating the requirement, this will simplify the process. |
A newer version of scipy exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only major question regards a parametrized test of mortar projection where one case was commented out.
STY: formatter Update src/porepy/grids/grid_extrusion.py Update src/porepy/grids/grid.py DOC: Removing comment and turn lower case local variable DOC: Formatting documentation STY: black on mandel_biot.py Co-Authored-By: Eirik Keilegavlen <Eirik.Keilegavlen@uib.no>
ed97bf1
to
d7606ee
Compare
test_operator::test_mortar_projections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final reformatting. Feel free to resolve and merge when you have considered that one.
Co-authored-by: Eirik Keilegavlen <Eirik.Keilegavlen@uib.no>
Updates the requirements on scipy to permit the latest version.
Release notes
Sourced from scipy's releases.
Commits
cfe8011
REL: 1.11.1 rel commit [wheel build]450d8aa
Merge pull request #18779 from tylerjereddy/treddy_1_11_1_prep6f942e8
DOC: update 1.11.1 relnotes145cec5
MAINT: fix unuran licensing0760bab
MAINT:linalg.det:Return scalars for singleton inputs (#18763)a1c6f99
MAINT:linalg:Use only NumPy types in lu5cdc2fe
MAINT:linalg:Remove memcpy from lud9ac3f3
FIX:linalg:Guard against possible permute_l out of bound behavior7ec5010
BUG: fix handling forfactorial(..., exact=False)
for 0-dim array inputs (#...90415c6
BUG: Fix work array construction for various weight shapes. (#18741)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)