Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix DREI to work with latest three-sdlib #2276

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RodrigoHamuy
Copy link
Contributor

Why

After releasing pmndrs/three-stdlib#392 we need to do this small change in DREI to fix some TS issues.

What

OrbitControlsChangeEvent is now more specific.

Checklist

  • Ready to be merged

Keeping it in draft until pmndrs/three-stdlib#392 is merged.

Copy link

vercel bot commented Dec 18, 2024

@RodrigoHamuy is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@CodyJasonBennett
Copy link
Member

Picked this into #2283.

@RodrigoHamuy
Copy link
Contributor Author

@CodyJasonBennett thanks !
This one is in draft because it needs this first pmndrs/three-stdlib#392
After that you won't need to ts ignore and things should work as usual.
Just to understand where we are going with this issue, base on #2283 code comments, will it be preferable instead to loosen back the types directly in three-types/three-ts-types#1398 ? Just asking to close the alternative solutions and avoid noise.
Thanks!

@CodyJasonBennett
Copy link
Member

No, it would not be preferable, as that is equally breaking and on the side of incorrect WRT to the types themselves. I think if remaining type issues only affect R3F usage, we loosen types there. Otherwise, we need to be creative to minimize breakage to vanilla users and collaborate with three types on this if possible.

@RodrigoHamuy
Copy link
Contributor Author

Okidok, in that case if you are happy @CodyJasonBennett I will close three-types/three-ts-types#1398 + pmndrs/react-three-fiber#3416 in favour of pmndrs/three-stdlib#392 + #2276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants