Do not use getElapsedTime on the main state clock, it messes up the delta #2341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very simple PR
Just used the Cloud component and I noticed it messed up 'the time'
I then saw that many components call
clock.gelapsedTime()
on the main clock instead of reading the.elapsedTime
propertyCalling
getElapsedTime()
update the delta of the clock and then returns.elapsedTime
Clock source in three.js
https://github.com/mrdoob/three.js/blob/master/src/core/Clock.js
Edit: In case you want the elapsed time precisely at the moment of the method call, use a separate clock for that.
I'd add that in 99% of case, you want the same elapsed time for all object in the current frame, making reading
.elapsedTime
even better thanclock.gelapsedTime()
to fully sync everything.This could be added to the gotcha section of the doc because I come across this issue in most projects I review.