Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(OrbitControls): make use of setPointerCapture" #305

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

gsimone
Copy link
Member

@gsimone gsimone commented Oct 12, 2023

This is a breaking change that causes the presence of OrbitControls to break pointer events, if desired it should be released in a major.

An alternative to reverting is making this opt-in via init options

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6b11dc3:

Sandbox Source
Vanilla Configuration

@CodyJasonBennett CodyJasonBennett merged commit f58eee2 into main Oct 12, 2023
@CodyJasonBennett CodyJasonBennett deleted the revert-297-patch-1 branch October 12, 2023 16:05
@github-actions
Copy link

🎉 This PR is included in version 2.27.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants