Highlight items in build queue on hover #931
Conversation
There was a problem hiding this comment.
Figured since I tried to do the same thing I'd leave my two cents. Feel free to ignore.
From the README
Pull requests should not contain the JS/CSS files generated by the build.
That means you'll need to remove the changes to evolve.css and main.js.
I also highly recommend using git rebase so you don't need to add merge commits every time there's conflicts.
| mouse_enter () { | ||
| const title = this.title; | ||
| $('.buildList .queued span[class^="res-"]').each(function () { | ||
| if (this.innerText === title) { |
There was a problem hiding this comment.
If you wanted to have this if be part of the selector, I found [id^=q${id}] span:first-child could replace .queued span[class^="res-"]
| }, | ||
| mouse_enter () { | ||
| $('.buildList .queued span').each(function () { | ||
| if (this.innerText === title) { |
There was a problem hiding this comment.
Similar selector suggestion here but slightly different. [id^=qarpa${project}] span:first-child
Somehow I missed this line. Thanks for pointing it out. I'll update all my open pull requests accordingly. |
fredden
force-pushed
the
highlight-build-queue
branch
from
56d718d
to
2015deb
Compare
When I have many items in the build queue, I sometimes end up adding to the queue in duplicate, as I miss that I've already queued a particular building. This pull request highlights items already in the build queue when hovered in the main pane.
I've recycled an existing colour for 'has text advanced', but this can be swapped for something more specific if preferred.
Fixes #1130
Closes #1129