New api #11
Open
New api #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can pipe to new processes, but not sure if that's working...
…ime problems otherwise
the process args were populated via temporary stack variables (intialiser lists), so having two processes created caused process arguments to overwrite each other.
One currently doesn't pass - it doesn't fail, mind you, but the test never terminates. A read that is happening in one of the tests is blocking, but it is reliant on the input of the previous process. Perhaps, I modify it that if there isn't a line immediately, it recursively requests a line from the parent process; this isn't neat and is prone to lockup either way. I also added a buffer to the stdout too, as some might build up in a process that is piped to, and not read frequently. Unfortunately, with that addition comes another problem - if the line isn't read explicitly (currently only via >>), the functors DO get called, but the buffer is never empties and is increasingly filled up. I also wrote a new testing program - it simply out puts a lot of data, so that we can test the pipe congestion better. I just wrote this one because we're gonna start writing the processes that are invoked from the testing program from scratch - enabling the tests to be run cross-platform.
Using operator>> or .read is prohibited for processes that have processes/files to output to, or if they have a functor to execute. The reason is to avoid massive memory increases for those who don't need the output, and only wish to use a functor. I need to fix the tests so they compile however. Tomorrow's job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's merge the couple new style functions in. This removes the async & process object, but these'll come soon.