Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various of the files in the current distribution include the
words "All rights reserved" in a copyright statement. In
some cases this includes files which are currently compiled
into libpng (the neon palette intrinsics and the loongarch
sx).
This draft PR fixes this by simply removing all such
files:
It seems reasonable that a FOSS distribution should only
include files that are subject to a FOSS license of one form
or another.
The "all rights reserved" comments seem to trump a
subsequent libpng license.
The libpng code itself should only include code
distributed with the libpng license and that should be
unambigous.
The PR includes fixups for the files which do get compiled
into libpng (the second commit). This will create an
unfortunate merge conflict which is why this is a draft; it
could be applied directly to libpng16 without damage but it
certainly conflicts with other PRs I have submitted for
libpng18.