Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copyright-issues #584

Closed
wants to merge 0 commits into from
Closed

copyright-issues #584

wants to merge 0 commits into from

Conversation

jbowler
Copy link
Contributor

@jbowler jbowler commented Sep 8, 2024

Various of the files in the current distribution include the
words "All rights reserved" in a copyright statement. In
some cases this includes files which are currently compiled
into libpng (the neon palette intrinsics and the loongarch
sx).

This draft PR fixes this by simply removing all such
files:

  1. It seems reasonable that a FOSS distribution should only
    include files that are subject to a FOSS license of one form
    or another.

  2. The "all rights reserved" comments seem to trump a
    subsequent libpng license.

  3. The libpng code itself should only include code
    distributed with the libpng license and that should be
    unambigous.

The PR includes fixups for the files which do get compiled
into libpng (the second commit). This will create an
unfortunate merge conflict which is why this is a draft; it
could be applied directly to libpng16 without damage but it
certainly conflicts with other PRs I have submitted for
libpng18.

  • Libpng taints
  • Fix builds for removal of copyrighted files

@jbowler jbowler changed the base branch from libpng16 to master September 8, 2024 01:57
@jbowler
Copy link
Contributor Author

jbowler commented Sep 8, 2024

@ctruta this may be a libpng16 issue. I don't understand the legal consequences and I only noticed the weird copyright statements because I was looking at the loongarch sx code and the ARM Ltd palette code.

@jbowler
Copy link
Contributor Author

jbowler commented Sep 8, 2024

All of the files except arm/palette_neon_intrinsics.c have what I assume is the original license somewhere, in gregbook there's a LICENSE file, the the Loongarch stuff the original license is still there (it looks like they copied one or other of the hardware variants). In the ARM Ltd case I had to go back to the original version to confirm that this was the original license.

@ctruta
Copy link
Member

ctruta commented Sep 8, 2024

Various of the files in the current distribution include the words "All rights reserved" in a copyright statement.

In my non-professional opinion, this is a non-issue.

Among a bunch of things that I do know is that real lawyers working for real corporation have vetted not only the libpng license (including the new "libpng license version 2.0"), but also the libpng code, with all of the enclosed copyright notices, to be 100% legit open-source software.

Submitting the "libpng license version 2.0" to OSI for approval as a legacy OSS license is a lower-priority (but not insignificant) item on my TODO list.

@jbowler jbowler deleted the libpng-taints branch September 9, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants