10-1_Update #1618
Open
10-1_Update #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o two rules, 10-15 was also created which checks that if humidification was specified in the proposed that it was also modeled in the baseline.
KarenWGard
reviewed
Feb 12, 2025
KarenWGard
reviewed
Feb 19, 2025
KarenWGard
reviewed
Feb 19, 2025
| - Case 3: Else if the baseline zone is not modeled with humidification when the proposed zone has humidficiation: `elif has_humidification_b == FALSE and has_humidification_p == TRUE: outcome == "FAIL"` | ||
| - Case 4: Else, humidification not modeled for the zone in proposed or baseline: `Else: outcome == "INAPPLICABLE"` | ||
|
|
||
| - Case 1: If the zone was modeled with humidification in the baseline and proposed then UNDETERMINED to check that the correct type of humidification was modeled (provide the zone_p.id and zone_b.id and the humidification_type_b in the output): `if has_humidification_b == TRUE and has_humidification_p == TRUE: outcome == "UNDETERMINED" and raise_message "This zone is modeled with humidification in the baseline and proposed. Check that the baseline system serving this zone is modeled with adiabatic humidification if the specified humidification system complies with 90.1 - 2019 Section 6.5.2.4, and that the baseline system serving this zone is modeled with non-adiabatic humidification if the specified system does not comply with Section 6.5.2.4."` |
There was a problem hiding this comment.
what if the proposed is modeled with humidification and the baseline is not? This would be an undetermined / Fail case, right?
Same for the case where the baseline has humidification an the proposed does not.
EDIT: Nevermind. This is covered in 10-15 - might want to add a note to clarify where these cases are covered.
There was a problem hiding this comment.
Do you have a suggested note? I am not sure this is needed since the logic aligns with the wording of the rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to have an undetermined and not_applicable outcome. Split into two rules, 10-15 was also created which checks that if humidification was specified in the proposed that it was also modeled in the baseline.