-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New_Rule_19_37 #1646
base: develop
Are you sure you want to change the base?
New_Rule_19_37 #1646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule 19-37.md looks good. Not sure what the changes to the other files are all about
docs/section19/Rule 19-37.md
Outdated
|
||
**Data Lookup:** None | ||
|
||
**Evaluation Context:** Each RulesetProjectDescription |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each RMD? Baseline RMD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be any RMD since yet to be designed areas in the proposed are autosized. Maybe I need to think if there is a way of eaily finding if there are yet to be designed areas in the proposed and only checking it in those sceanrios
docs/section19/Rule 19-37.md
Outdated
## Check Applicability: | ||
- Set default applicability: `rule_applicability = True` | ||
- Get the weather for the ruleset model description: `weather = RulesetModelDescription.weather` | ||
- If the design days were incorrectly defined in terms of type in thr RPD then rule is NOT_APPLICABLE: `if not (weather.cooling_dry_bulb_temp_design_day_type == "COOLING_1_0" and weather.heating_dry_bulb_temp_design_day_type == "HEATING_99_6" and weather.cooling_wet_bulb_temp_design_day_type == "COOLING_1_0"):` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self, add note that for the proposed this is only applicable if there are yet to be designed HVAC systems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment- looks like
cooling_dry_bulb_temp_design_day_type was renamed to CoolingDesignDayOptions
similarly, heating_dry_bulb_temp_design_day_type was renamed to HeatingDesignDayOptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@supriyagoel Can you please clarify what you mean? I think I have the correct labels, what you're referring to are the enumerations but I could be missing something so please let me know if I am. Thanks!
@KarenWGard Is this still an issue? I'm having trouble understanding what this refers to. |
… a correction to the name of a data element that was recently modified and updated a typo in the rule ID .
New rule 19-37 was added so that 19-3 could be made into a Primary rule with a pass and fail.