RCT/JX/update get_building_lab_zones_list function #1670
Merged
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weilixu
reviewed
Mar 7, 2025
| != LightingSpaceOptions.LABORATORY_EXCEPT_IN_OR_AS_A_CLASSROOM | ||
| or space.get("function") != SpaceFunctionOptions.LABORATORY | ||
| and space.get("lighting_space_type") | ||
| == LightingSpaceOptions.LABORATORY_EXCEPT_IN_OR_AS_A_CLASSROOM |
There was a problem hiding this comment.
The logic says: either are defined. And use whichever are defined. If they conflict then we can't determine whether it's a lab.
I think this should be
if (space.function == None and space.lighting_space_type == LABORATORY_EXCEPT_IN_OR_AS_A_CLASSROOM) or (space.function == LABORATORY and space.lighting_space_type == None)
or (space.function == LABORATORY and space.lighting_space_type == LABORATORY_EXCEPT_IN_OR_AS_A_CLASSROOM)
-> space is lab.I think in your logic, it is missing the third condition: (space.function == LABORATORY and space.lighting_space_type == LABORATORY_EXCEPT_IN_OR_AS_A_CLASSROOM)
There was a problem hiding this comment.
Good catch! I misunderstood the logic. It is corrected now.
weilixu
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the logic of get_building_lab_zones_list function and the test. Fixes #1463 >