Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added department-members-list #900

Merged
merged 21 commits into from
Dec 26, 2024
Merged

Added department-members-list #900

merged 21 commits into from
Dec 26, 2024

Conversation

watana2
Copy link
Contributor

@watana2 watana2 commented Dec 18, 2024

Q A
New sample? yes

What's in this Pull Request?

This sample demonstrate how to turn list items into a custom table.

@tecchan1107 tecchan1107 self-assigned this Dec 19, 2024
@tecchan1107
Copy link
Collaborator

tecchan1107 commented Dec 23, 2024

Thank you for all your great samples!

I have one question and one request. I apologize for the inconvenience, but I would appreciate it if you could check it out when you have a moment.

Question

In the README, you mentioned that “Name (with picture and details) needs to be changed”. Is this to solve the problem that the user's jobTitle is not displayed?

When I tested this sample in my environment, the jobTitle was not displayed before changing to "Name (with picture and details)", but after changing to "Name (with picture and details)", the jobTitle was displayed.

*I am going to create an issue in sp-dev-docs if you are experiencing the same thing.

Request

The sample name “Table” seems a bit abstract, so could you please change it to something more concrete?

Example:

  • team-members-table
  • department-members-list

@watana2
Copy link
Contributor Author

watana2 commented Dec 23, 2024

Thank you for your suggestions. I have renamed the sample and updated the relevant information.

Yes, I had the same experience. I've discovered that to be able to display jobTitle or department field from the Person column, it needs to be changed to Name (with picture and details). There are more fields such as MobilePhone, WorkPhone, City, Country,...but it doesn't work.

@tecchan1107 tecchan1107 changed the title Table Added department-members-list Dec 26, 2024
@tecchan1107 tecchan1107 merged commit 554c0fa into pnp:master Dec 26, 2024
@tecchan1107
Copy link
Collaborator

Thanks for the answer and the update!

I also created the following issue and reported it to Microsoft.
SharePoint/sp-dev-docs#10063

@watana2 watana2 deleted the table branch December 26, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants