Moves collecting telemetry to a separate process #5327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like there's a tiny merge conflict here @waldekmastykarz. Could you have a look at it? |
|
Will do 👍 |
waldekmastykarz
force-pushed
the
telemetry-async
branch
from
185bdcd to
b4311e7
Compare
|
Ready @milanholemans 💪 |
martinlingstuyl
approved these changes
Oct 12, 2023
|
Merged manually, thanks for contributing, you rock! 😊🌶️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves collecting telemetry to a separate process to improve CLI's performance and make collecting telemetry events non-blocking for the execution of CLI commands.