Extends 'external connection schema add' with wait. Closes #5532 #5599
Conversation
|
Hi @waldekmastykarz, today we merged a PR with renames of the entire external command group. Hence the merge conflicts... could you maybe fix them? |
|
On it! |
waldekmastykarz
force-pushed
the
externalconnection-add-wait
branch
2 times, most recently
from
93f6487 to
c040fa5
Compare
waldekmastykarz
changed the title
Jwaegebaert
added
the
hacktoberfest-accepted
There was a problem hiding this comment.
I've nothing to add regarding the --wait functionality. Works smoothly @waldekmastykarz.
I'm a bit curious about the second addition you mentioned in the issue. Is that something you want to track in a separate issue and first implement the await logic?
|
Good catch @Jwaegebaert, seems like I totally lost track of it. Sending the location to stdout is a small change, so let's bring it in straight away. Let me update the PR |
waldekmastykarz
force-pushed
the
externalconnection-add-wait
branch
from
c040fa5 to
f6f7cef
Compare
There was a problem hiding this comment.
Pardon for the delay but awesome work @waldekmastykarz. One note I've is that we should mention in the docs that we'll return the job status URL in case they want to follow it up manually. I can add this manually during the merging, I was thinking something along the lines of this:
## Response
Upon executing the command, you'll receive the job status URL. This URL enables manual checking of the job's progress if automated polling fails or for interactive monitoring purposes.
```text
"https://graph.microsoft.com/v1.0/external/connections/MyApp/operations/795b6888-4093-0fe7-6270-ddbcac9ebd3a"
```
|
All good. Great idea @Jwaegebaert. Please do |
Extends 'search externalconnection schema add' with wait. Closes #5532