-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds spp model apply
command. Closes #6119
#6453
base: main
Are you sure you want to change the base?
Conversation
Thank you for the PR and the additional info @mkm17! We'll get back to you ASAP. |
@mkm17 I added the |
c69155f
to
f366ea7
Compare
@mkm17, could you resolve the merge conflicts, please? |
f366ea7
to
d7d8e52
Compare
hi @milanholemans , I apologize for the delay, but I finally found some time to resolve the conflicts here. I have also reviewed the code and made the changes you pointed out in some other |
Hi @mkm17, sorry again, could you resolve the conflicts? Will try to review it ASAP when they are resolved. |
d7d8e52
to
4bd3c1e
Compare
Conflicts resolved :) |
Adds
spp model apply
command. Closes #6119I realized I forgot to add a parameter needed to locate the content site where the model is stored:
contentCenterUrl
Let me know if name is ok. We can change it to modelContentSiteUrl or something else.
I also modified the
viewOption
parameter. During testing, I saw that it’s possible to set three different values:NewViewAsDefault
,DoNotChangeDefault
,TileViewAsDefault
The API does not return an error when attempting to apply a model to a custom SharePoint List. However, I’ve added a condition to check if the list is a document library. I hope that’s ok.
potentially, when the
spp model get
command is approved, thegetModel
function from this command should be exported to thespp.ts
file so it can be used by both commands.