Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command: m365 pp website get, Closes #6259 #6486

Closed
wants to merge 4 commits into from

Conversation

nicodecleyre
Copy link
Contributor

Closes #6259

@milanholemans
Copy link
Contributor

Thank you for the contribution @nicodecleyre. Could you fix the workflow failure?

@martinlingstuyl martinlingstuyl self-assigned this Dec 13, 2024
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments @nicodecleyre, but on the whole this looks good!

docs/docs/cmd/pp/website/website-get.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/pp/website/website-get.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/pp/website/website-get.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/pp/website/website-get.mdx Outdated Show resolved Hide resolved
src/m365/pp/commands/website/website-get.ts Outdated Show resolved Hide resolved
src/m365/pp/commands/website/website-get.ts Outdated Show resolved Hide resolved
@martinlingstuyl martinlingstuyl marked this pull request as draft December 13, 2024 13:07
@nicodecleyre nicodecleyre marked this pull request as ready for review December 25, 2024 11:26
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @nicodecleyre! I'll merge it sometime soon!

docs/docs/cmd/pp/website/website-get.mdx Show resolved Hide resolved
src/m365/pp/commands/website/website-get.ts Show resolved Hide resolved
@martinlingstuyl
Copy link
Contributor

Merged manually, thank you!!! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: m365 pp website get
3 participants