Merge pull request #321 from pnp/preview

Merge 4.0.1 into master
pnp · Jun 28, 2022 · e02e11c · e02e11c
2 parents 1cc7359 + d9b87c8
commit e02e11c
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/packages/generator-teams/CHANGELOG.md b/packages/generator-teams/CHANGELOG.md
@@ -6,6 +6,16 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
 
+## [*4.0.1*]- <*2022-06-28*>
+
+### Fixes
+
+* Fixed an issue with tab configuration
+
+### Changes
+
+* Updated dependencies
+
 ## [*4.0.0*]- <*2022-06-23*>
 
 ### Added

diff --git a/packages/generator-teams/package.json b/packages/generator-teams/package.json
@@ -1,6 +1,6 @@
 {
   "name": "generator-teams",
-  "version": "4.0.0",
+  "version": "4.0.1",
   "description": "Yeoman generator for Microsoft Teams Apps, including support for extending Teams apps to other parts of the Microsoft 365 ecosystem.",
   "main": "generators/app/index.js",
   "scripts": {

diff --git a/packages/generator-teams/src/app/GeneratorTeamsApp.ts b/packages/generator-teams/src/app/GeneratorTeamsApp.ts
@@ -624,7 +624,7 @@ export class GeneratorTeamsApp extends Generator {
         // if we have added any react based components
         if (this.options.reactComponents) {
             Yotilities.addAdditionalDeps([
-                ["msteams-react-base-component", "^4.0.0"]
+                ["msteams-react-base-component", "^4.0.1"]
             ], this.fs);
         }
 

diff --git a/.../generator-teams/src/tab/templates/src/client/{tabName}/{tabReactComponentName}Config.tsx b/.../generator-teams/src/tab/templates/src/client/{tabName}/{tabReactComponentName}Config.tsx
@@ -21,8 +21,9 @@ export const <%=tabReactComponentName%>Config = () => {
             suggestedDisplayName: "<%=tabTitle%>",
             removeUrl: host + "/<%=tabName%>/remove.html?theme={theme}",
             entityId: entityId.current
+        }).then(() => {
+            saveEvent.notifySuccess();
         });
-        app.notifySuccess();
     };
 
     useEffect(() => {