Adding Get-PnPPowerPlatformConnector
#3487
Conversation
src/Commands/PowerPlatform/Environment/GetPowerPlatformConnectors.cs
Outdated
Show resolved
Hide resolved
src/Commands/PowerPlatform/Environment/GetPowerPlatformConnectors.cs
Outdated
Show resolved
Hide resolved
| { | ||
| WriteVerbose($"Retrieving all Connectors within environment '{environmentName}'"); | ||
|
|
||
| var connectors = GraphHelper.GetResultCollectionAsync<Model.PowerPlatform.Environment.PowerPlatformConnector>(Connection, $"https://api.powerapps.com/providers/Microsoft.PowerApps/apis?api-version=2016-11-01&$filter=environment eq '{environmentName}' and isCustomApi eq 'True'", AccessToken).GetAwaiter().GetResult(); |
There was a problem hiding this comment.
Same check here as well for GCC clouds
There was a problem hiding this comment.
file commited by mistake..removed
src/Commands/PowerPlatform/Environment/GetPowerPlatformSolution.cs
Outdated
Show resolved
Hide resolved
| WriteVerbose($"Using default environment as retrieved '{environmentName}'"); | ||
| } | ||
|
|
||
| string accessTokenForGettingSolutions = TokenHandler.GetAccessTokenforPowerPlatformSolutions(this, Connection, dynamicsScopeUrl); |
There was a problem hiding this comment.
Can we use RequiredMinimalApiPermissions attribute instead of this ? Please check some graph cmdlets where we use it.
There was a problem hiding this comment.
This token that we are getting would have a dynamic URL based on the Power Platform environment....so token has to be get for url like "https://orge12323.crm8.dynamics.com" and this will change - so this would not worked with RequiredMinimalPermissions? Let me know if you think there is any other way to get token
| string environmentName = null; | ||
| string dynamicsScopeUrl = null; | ||
| var environments = GraphHelper.GetResultCollectionAsync<Model.PowerPlatform.Environment.Environment>(Connection, "https://management.azure.com/providers/Microsoft.ProcessSimple/environments?api-version=2016-11-01", AccessToken).GetAwaiter().GetResult(); | ||
| if (ParameterSpecified(nameof(Environment))) | ||
| { | ||
| environmentName = Environment.GetName().ToLower(); | ||
| WriteVerbose($"Using environment as provided '{environmentName}'"); | ||
| dynamicsScopeUrl = environments.FirstOrDefault(e => e.Properties.DisplayName.ToLower() == environmentName || e.Name.ToLower() == environmentName)?.Properties.LinkedEnvironmentMetadata.InstanceApiUrl; | ||
| } | ||
| else | ||
| { | ||
| environmentName = environments.FirstOrDefault(e => e.Properties.IsDefault.HasValue && e.Properties.IsDefault == true)?.Name; | ||
| dynamicsScopeUrl = environments.FirstOrDefault(e => e.Properties.IsDefault.HasValue && e.Properties.IsDefault == true)?.Properties.LinkedEnvironmentMetadata.InstanceApiUrl; | ||
| if (string.IsNullOrEmpty(environmentName)) | ||
| { | ||
| throw new Exception($"No default environment found, please pass in a specific environment name using the {nameof(Environment)} parameter"); | ||
| } | ||
|
|
||
| WriteVerbose($"Using default environment as retrieved '{environmentName}'"); | ||
| } |
There was a problem hiding this comment.
Can you move this code to a utility ?
It could be something like:
var env = Utility.GetEnvironment
Move the logic there and keep the cmdlet code itself smaller
There was a problem hiding this comment.
I was looking at how can I move it - but If you think about it we would only be able to move line 24, because once we got environments. I need conditions to find the environment name - (given by the user) also the Environment instance URL...so would have to keep that logic in the command itself...otherwise I would have to create separate model class for Env with only two attributes name and instanceURL.
any other thoughts?
| namespace PnP.PowerShell.Commands.PowerPlatform.Environment | ||
| { | ||
| [Cmdlet(VerbsCommon.Get, "PnPPowerPlatformConnectors")] | ||
| public class GetPowerPlatformConnectors : PnPAzureManagementApiCmdlet |
There was a problem hiding this comment.
Would require this I think:
[RequiredMinimalApiPermissions("https://management.azure.com/.default")]
| namespace PnP.PowerShell.Commands.PowerPlatform.Environment | ||
| { | ||
| [Cmdlet(VerbsCommon.Get, "PnPPowerPlatformSolution")] | ||
| public class GetPowerPlatformSolution: PnPAzureManagementApiCmdlet |
There was a problem hiding this comment.
Same here:
Would require this I think:
[RequiredMinimalApiPermissions("https://management.azure.com/.default")]
There was a problem hiding this comment.
For PowerPlatform related commands I don't think it would require...as not seeing in any other commands also.
|
hi @gautamdsheth - did you get a chance to review the updated comments? |
…match cdmdlet name
|
If I may anothe review comment as well, could you rename the cmdlet to Get-PnPPowerPlatformCustomConnector? It only returns the custom connectors, not the out of the box ones. I find the current name confusing in this sense. |
KoenZomers
changed the title
Get-PnPPowerPlatformConnectorGet-PnPPowerPlatformConnector
…ngle connector based on name...
This is very good observation, changed the cmdlet to have custom word in it... |
Type
[x] New Feature
What is in this Pull Request ?
Added new command to Get PowerPlatform Solutions. This command would help to get the PowerPlatform solution for the given enviorment.