-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended Restore-PnPRecycleBinItem functionality to efficiently restore selected set of items in bulk #4705
base: dev
Are you sure you want to change the base?
Conversation
…ing another parameterset for providing an array of Ids of items to restore in bulk. This will allow the users to deal with the scenarios where a lot (but not all) of files need to be restored. Caller can provide a list of Ids of items to bulk restore them. Bulk restore in this case will use REST API to restore items quickly. It also uses a fall back logic to deal with batch errors and automatically switches to individual restore, if needed.
Thanks @namwar for your efforts! Looks cool! Left two comments for you. Would appreciate it if you could have a look at those. |
…k to log reasons for failure to restore an item, in case of an error.
Please have a look at my comments on your feedback. I have clarified your concern. I think you can merge my code. |
Looks good @namwar, thanks! |
Still missing your change in the documentation by the way. Can you update Get-PnPRecycleBinItem.md to reflect this new option? |
You also don't seem to have checked the option to allow us to update your PR branch so I can add the changelog entry to it. Can you enable that please? |
I will update the Get-PnPRecycleBinItem.md quickly |
Added information about the new parameter set. Added example and parameter information.
I have updated the documentation/Restore-PnPRecycleBinItem.md. Please have a look. |
Type
What is in this Pull Request ?
Extended the functionality of Restore-PnPRecycleBinItem cmdlet by adding another parameter set. The new parameter set allows the user to provide a string array of Recycle Bin item IDs. It will enable users to deal with scenarios where many (but not all) items need to be restored.
The caller can provide a list of IDs of items to bulk restore them. Bulk restore in this case will use REST API to restore items efficiently, in bulk. It also uses a fallback logic to deal with batch errors and automatically switches to individual restore, if needed.