Upgrade to SPFx 1.20

pnp · Oct 20, 2024 · 6936409 · 6936409
1 parent 8831065
commit 6936409
Show file tree

Hide file tree

Showing 27 changed files with 28,578 additions and 20,966 deletions.
diff --git a/samples/react-securitygrid/.eslintrc.js b/samples/react-securitygrid/.eslintrc.js
@@ -0,0 +1,5 @@
+require('@rushstack/eslint-config/patch/modern-module-resolution');
+module.exports = {
+  extends: ['@microsoft/eslint-config-spfx/lib/profiles/react'],
+  parserOptions: { tsconfigRootDir: __dirname }
+};
diff --git a/samples/react-securitygrid/.gitignore b/samples/react-securitygrid/.gitignore
@@ -9,6 +9,7 @@ node_modules
 # Build generated files
 dist
 lib
+release
 solution
 temp
 *.sppkg
@@ -30,3 +31,6 @@ obj
 
 # Styles Generated Code
 *.scss.ts
+
+# heft folder
+.heft
diff --git a/samples/react-securitygrid/.nvmrc b/samples/react-securitygrid/.nvmrc
@@ -0,0 +1 @@
+v18.20.4
diff --git a/samples/react-securitygrid/.yo-rc.json b/samples/react-securitygrid/.yo-rc.json
@@ -3,10 +3,15 @@
     "isDomainIsolated": false,
     "isCreatingSolution": false,
     "packageManager": "npm",
-    "version": "1.10.0",
+    "version": "1.20.0",
     "libraryName": "spsecurity-webpart-3",
     "libraryId": "788271fb-ee9b-40df-8381-eb3dc70d1982",
     "environment": "spo",
-    "componentType": "webpart"
+    "componentType": "webpart",
+    "nodeVersion": "18.20.4"
+  },
+  "sdkVersions": {
+    "@microsoft/teams-js": "2.24.0",
+    "@microsoft/microsoft-graph-client": "3.0.2"
   }
 }
diff --git a/samples/react-securitygrid/README.md b/samples/react-securitygrid/README.md
@@ -87,8 +87,8 @@ This is a port of an Angular 1.3 SharePoint hosted App at https://github.com/rus
 | Every SPFx version is only compatible with specific version(s) of Node.js. In order to be able to build this sample, please ensure that the version of Node on your workstation matches one of the versions listed in this section. This sample will not work on a different version of Node.|
 |Refer to <https://aka.ms/spfx-matrix> for more information on SPFx compatibility.   |
 
-![SPFx 1.10](https://img.shields.io/badge/SPFx-1.10.0-green.svg) 
-![Node.js v10 | v8](https://img.shields.io/badge/Node.js-v10%20%7C%20v8-green.svg) 
+![SPFx 1.20](https://img.shields.io/badge/SPFx-1.20.0-green.svg) 
+![Node.js v18.20.4](https://img.shields.io/badge/Node.js-%20v18.20.4-green.svg)
 ![Compatible with SharePoint Online](https://img.shields.io/badge/SharePoint%20Online-Compatible-green.svg)
 ![Does not work with SharePoint 2019](https://img.shields.io/badge/SharePoint%20Server%202019-Incompatible-red.svg)
 ![Does not work with SharePoint 2016 (Feature Pack 2)](https://img.shields.io/badge/SharePoint%20Server%202016%20(Feature%20Pack%202)-Incompatible-red.svg "SharePoint Server 2016 Feature Pack 2 requires SPFx 1.1")
@@ -102,7 +102,7 @@ This is a port of an Angular 1.3 SharePoint hosted App at https://github.com/rus
 
 ## Prerequisites
 
-> React, Office-UI-Fabric, sp-pnp-js, lodash
+> React, Fluent UI React, sp-pnp-js, lodash
 
 ## Contributors
 
@@ -112,6 +112,7 @@ This is a port of an Angular 1.3 SharePoint hosted App at https://github.com/rus
 
 Version|Date|Comments
 -------|----|--------
+1.0.6.0|Oct 20, 2024 | Upgrade to SPFx 1.20
 1.0.5.0|March 6, 2021 | Added webApiPermission request
 1.0.0.4|February 22, 2021 | Added support for AD groups
 1.0.0.3|October 28, 2020 | Update to office-ui-fabric-react 7.148.1, fixing icons and indentation for sub-folders 

diff --git a/samples/react-securitygrid/config/copy-assets.json b/samples/react-securitygrid/config/copy-assets.json
diff --git a/samples/react-securitygrid/config/deploy-azure-storage.json b/samples/react-securitygrid/config/deploy-azure-storage.json
@@ -1,6 +1,6 @@
 {
   "$schema": "https://developer.microsoft.com/json-schemas/spfx-build/deploy-azure-storage.schema.json",
-  "workingDir": "./temp/deploy/",
+  "workingDir": "./release/assets/",
   "account": "<!-- STORAGE ACCOUNT NAME -->",
   "container": "spsecurity-webpart-3",
   "accessKey": "<!-- ACCESS KEY -->"

diff --git a/samples/react-securitygrid/config/package-solution.json b/samples/react-securitygrid/config/package-solution.json
@@ -6,15 +6,46 @@
         "name": "spsecurity-webpart-3-client-side-solution",
         "id": "788271fb-ee9b-40df-8381-eb3dc70d1982",
         "version": "1.0.4.0",
-        "webApiPermissionRequests": [{
+        "webApiPermissionRequests": [
+            {
                 "resource": "Microsoft Graph",
                 "scope": "Group.Read.All"
             },
             {
                 "resource": "Microsoft Graph",
                 "scope": "GroupMember.Read.All"
             }
-        ]
+        ],
+        "developer": {
+            "name": "Russel Gove",
+            "privacyUrl": "",
+            "termsOfUseUrl": "",
+            "websiteUrl": "https://github.com/russgove",
+            "mpnId": "Undefined-1.20.0"
+        },
+        "metadata": {
+            "shortDescription": {
+              "default": "Security Grid Web Part"
+            },
+            "longDescription": {
+              "default": "React-securitygrid is an SPFX web part that uses React and Office-UI-Fabric to render a grid showing which users have access to which lists/libraries/folders/files on a Web"
+            },
+            "screenshotPaths": [],
+            "videoUrl": "",
+            "categories": []
+          },
+          "features": [
+            {
+              "title": "Security Grid Web Part Feature",
+              "description": "The feature that activates Security Grid Web Part from the react-securitygrid solution.",
+              "id": "41e37f03-2ea8-4f19-b77a-f2121a1e7c45",
+              "version": "1.0.4.0",
+              "componentIds": [
+                "41e37f03-2ea8-4f19-b77a-f2121a1e7c45"
+              ]
+            }
+          ]
+
     },
     "paths": {
         "zippedPackage": "solution/spsecurity-webpart-3.sppkg"

diff --git a/samples/react-securitygrid/config/sass.json b/samples/react-securitygrid/config/sass.json
@@ -0,0 +1,3 @@
+{
+    "$schema": "https://developer.microsoft.com/json-schemas/core-build/sass.schema.json"
+}
diff --git a/samples/react-securitygrid/config/serve.json b/samples/react-securitygrid/config/serve.json
@@ -1,15 +1,6 @@
 {
-    "$schema": "https://developer.microsoft.com/json-schemas/core-build/serve.schema.json",
+    "$schema": "https://developer.microsoft.com/json-schemas/spfx-build/spfx-serve.schema.json",
     "port": 4321,
-    "initialPage": "https://localhost:5432/workbench",
-    "https": true,
-    "api": {
-        "port": 5432,
-        "entryPath": "node_modules/@microsoft/sp-webpart-workbench/lib/api/"
-    },
-    "serveConfigurations": {
-        "default": {
-            "pageUrl": "https://russellwgove.sharepoint.com/sites/testazad/_layouts/15/workbench.aspx"
-        }
-    }
+    "initialPage": "https://{tenantDomain}/_layouts/workbench.aspx",
+    "https": true
 }
diff --git a/samples/react-securitygrid/gulpfile.js b/samples/react-securitygrid/gulpfile.js
@@ -8,4 +8,13 @@ build.addSuppression(`Warning - [sass] The local CSS class 'ms-DetailsHeader-cel
 build.addSuppression(`Warning - [sass] The local CSS class 'ms-List-cell' is not camelCase and will not be type-safe.`);
 build.addSuppression(`Warning - [sass] The local CSS class 'ms-DetailsRow' is not camelCase and will not be type-safe.`);
 
+var getTasks = build.rig.getTasks;
+build.rig.getTasks = function () {
+  var result = getTasks.call(build.rig);
+
+  result.set('serve', result.get('serve-deprecated'));
+
+  return result;
+};
+
 build.initialize(gulp);