Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workbench-customizer update to SPFx 1.18.2 and fix JS warnings causing the browser to crash #4502

Conversation

joelfmrodrigues
Copy link
Contributor

What's in this Pull Request?

Workbench-customizer update to SPFx 1.18.2 and fix JS warnings causing the browser to crash.

Node Version

Node version used: v18.18.2

Checklist

  • My pull request affects only ONE sample.
  • My sample does not build with any warnings
  • I have updated the README file.
  • My README has at least one static high-resolution screenshot (i.e. not a GIF)
  • My README contains complete setup instructions, including pre-requisites and permissions required

@hugoabernier hugoabernier merged commit b5de911 into pnp:main Dec 29, 2023
1 check passed
@hugoabernier
Copy link
Collaborator

hugoabernier commented Dec 29, 2023

Thank you for this update @joelfmrodrigues ! This continues to be an awesome tool for all SPFx developers out there. It's create to see an updated version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

js-workbench-customizer - Workbench Customizer Hangs The browser
2 participants