Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image aspect fix #5362

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Image aspect fix #5362

merged 3 commits into from
Jan 13, 2025

Conversation

ishaisagi-hns
Copy link
Contributor

  • New sample
  • [ X] Bug fix/update
  • Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

  1. Major: Fix for aspect ration defaults (previous change was getting the checkbox to be selected by default, but the editing controls ignored it until the checkbox was clicked again)
  2. Major: image upload was not implemented before. the new code will ensure a folder for the current page in the site's "Site Assets" library and upload the selected file to that folder.
  3. added webpart settings that allow the page editor to determine what source of photos are allowed in the webpart

Node Version

8 or 10

Node version used:
8

  • [X ] My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

@hugoabernier hugoabernier merged commit 6df2707 into pnp:main Jan 13, 2025
3 checks passed
@hugoabernier
Copy link
Collaborator

Many thanks @ishaisagi-hns for your update! Always appreciated!.

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

@ishaisagi-hns
Copy link
Contributor Author

Hello @hugoabernier ,
I keep finding issues with this sample - bugs that mean it is not very useful on SharePoint 2019 (and maybe even cloud). I am now working on a fork to make a 2019 version of it - but not sure if you'd want that merged or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants