Support installation from custom NPM registry via .npmrc
#179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #177.
This PR adds support for custom NPM registry configurations, allowing the action to install PNPM from there.
With this, the action reads a potential custom registry configuration from
.npmrc
if it exists, and uses the result by running the install script with a corresponding--registry <custom>
flag.Here are some scenarios I tested using this script:
Test Results
Note
I was also considering an action parameter, but this feels more natural - if you are already using a custom registry via
.npmrc
, then you'll likely want your package manager to be fetched form there as well.But I could also see a parameter being helpful for some setups, perhaps even acting as an override to the
.npmrc
registry configuration. Maybe as a follow-up?Any feedback is greatly appreciated!