Revert "fix(npm-lifecycle): properly handle SIGINT from child process (…

…#41)"

This reverts commit d495284.

index.js

@@ -279,7 +279,7 @@ function runCmd_ (cmd, pkg, env, wd, opts, stage, unsafe, uid, gid, cb_) {
   proc.on('close', (code, signal) => {
     opts.log.silly('lifecycle', logid(pkg, stage), 'Returned: code:', code, ' signal:', signal)
     let err
-    if (signal && signal !== 'SIGINT') {
+    if (signal) {
       err = new PnpmError('CHILD_PROCESS_FAILED', `Command failed with signal "${signal}"`)
       process.kill(process.pid, signal)
     } else if (code) {
@@ -305,7 +305,7 @@ function runCmd_ (cmd, pkg, env, wd, opts, stage, unsafe, uid, gid, cb_) {
       if (er.code !== 'EPERM') {
         er.code = 'ELIFECYCLE'
       }
-      fs.stat(opts.dir, (statError) => {
+      fs.stat(opts.dir, (statError, d) => {
         if (statError && statError.code === 'ENOENT' && opts.dir.split(path.sep).slice(-1)[0] === 'node_modules') {
           opts.log.warn('', 'Local package.json exists, but node_modules missing, did you mean to install?')
         }

test/fixtures/count-to-10/package.json

@@ -3,7 +3,6 @@
   "version": "1.0.0",
   "scripts": {
     "postinstall": "node postinstall",
-    "signal-abrt": "echo 'signal-exit script' && kill -s ABRT $$",
-    "signal-int": "echo 'signal-int script' && kill -s INT $$"
+    "signal-exit": "echo 'signal-exit script' && kill -s ABRT $$"
   }
 }

test/index.js

@@ -183,71 +183,13 @@ test('throw error signal kills child', async function (t) {
   const dir = fixture
   const pkg = require(path.join(fixture, 'package.json'))
 
-  await t.rejects(async () => {
-    await lifecycle(pkg, 'signal-abrt', fixture, {
+  t.rejects(async () => {
+    await lifecycle(pkg, 'signal-exit', fixture, {
       stdio: 'pipe',
       log,
       dir,
       config: {}
     })
+    stubProcessExit.restore()
   })
-
-  stubProcessExit.restore()
-})
-
-test('no error on INT signal from child', async function (t) {
-  const fixture = path.join(__dirname, 'fixtures', 'count-to-10')
-
-  const verbose = sinon.spy()
-  const silly = sinon.spy()
-  const info = sinon.spy()
-
-  const stubProcessExit = sinon.stub(process, 'kill').callsFake(noop)
-
-  const log = {
-    level: 'silent',
-    info,
-    warn: noop,
-    silly,
-    verbose,
-    pause: noop,
-    resume: noop,
-    clearProgress: noop,
-    showProgress: noop
-  }
-
-  const dir = fixture
-  const pkg = require(path.join(fixture, 'package.json'))
-
-  await t.resolves(async () => {
-    await lifecycle(pkg, 'signal-int', fixture, {
-      stdio: 'pipe',
-      log,
-      dir,
-      config: {}
-    })
-  })
-
-  stubProcessExit.restore()
-
-  t.ok(
-    !info.calledWithMatch(
-      'lifecycle',
-      'undefined~signal-int:',
-      'Failed to exec signal-int script'
-    ),
-    'INT signal intercepted incorrectly'
-  )
-
-  t.ok(
-    silly.calledWithMatch(
-      'lifecycle',
-      'undefined~signal-int:',
-      'Returned: code:',
-      null,
-      ' signal:',
-      'SIGINT'
-    ),
-    'INT signal reported'
-  )
 })