pass args to scripts

[Yakiyo]

Pass any additional arguments passed after script name in command invocation to the script.

Resolves #48

[Yakiyo]

Any status on this?

[KSXGitHub]

What about the arguments that contain whitespaces? Don't we need to escape them before passing the command to sh -c?

Related crates: https://docs.rs/shell-escape/0.1.5/shell_escape/

This crate is better: https://docs.rs/shell-quote/0.3.0/shell_quote/sh/fn.escape_into.html

[Yakiyo]

What about the arguments that contain whitespaces? Don't we need to escape them before passing the command to sh -c?

Related crates: https://docs.rs/shell-escape/0.1.5/shell_escape/

Not sure what that would look like. care to give an example? How does pnpm do it?

[KSXGitHub]

Not sure what that would look like. care to give an example? How does pnpm do it?

pnpm for sure handles whitespace.

But for how pnpm did it, you must ask @zkochan.

If you ask me, I have already answered: Just use the crate I suggested, I don't really care how exactly pnpm did it.

[KSXGitHub]

Just use the crate I suggested

Actually, I think this crate is better: https://docs.rs/shell-quote/0.3.0/shell_quote/sh/fn.escape_into.html

You do have to change the type of RunArgs::args back to Vec<OsString> though.

[Yakiyo]

pnpm for sure handles whitespace.

i tried it out a few seconds ago but clap handles it.
passing pn run test "Hello World" "! !" takes it as two args instead of 4.

[KSXGitHub]

i tried it out a few seconds ago but clap handles it.
passing pn run test "Hello World" "! !" takes it as two args instead of 4.

Clap handles it but the command you pass to sh -c doesn't.

[Yakiyo]

okay i understand the issue now

[KSXGitHub]

If you used my list-args.js, the issue would have been clearer.

Also, please use the shell-quote crate as suggested here.

[Yakiyo]

@KSXGitHub not sure if i did anything wrong but it doesnt seem to work

and based on the ci, shell quote is failing to build on windows.

[Yakiyo]

env::args_os itself is stripping away the quotes

[KSXGitHub]

shell quote is failing to build on windows.

This was an oversight on my part. I was not aware that shell-quote is not cross-platform. Let's try os_display.

Also, changing the type of RunArgs::args to Vec<OsString> seems to lead to verbose code, let's reverse that.

[KSXGitHub]

See https://github.com/Yakiyo/pn/pull/1

[Yakiyo]

See Yakiyo#1

merged

[KSXGitHub]

Windows CI fails

CLRF strikes again.

[KSXGitHub]

Can you merge this? https://github.com/Yakiyo/pn/pull/2

[Yakiyo]

Can you merge this? Yakiyo#2

done