Improve font fmaily #446
Merged
Improve font fmaily #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@liberaldev is attempting to deploy a commit to the pnpm Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zkochan
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default font-family in tailwind is very Mac-centric and lacks consideration for Windows environments, especially CJK Windows environments.(Note: https://infinnie.github.io/blog/2017/systemui.html)
Currently, tailwind's font-family for sans serif is preceded by system-ui, which results in rendering Malgun Gothic instead of Segoe UI in Korean window environments. Malgun Gothic's readability in English is horrendously bad. This PR fixes that issue.
This is a screenshot of the at-proto site in a Korean Windows environment. You can see that the English is not very readable.
This is a screenshot taken after removing system-ui from the font-family. You can see that the Segoe ui is rendered and is more readable.