Replaced Gomill with its submodule #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olbox.py and r2csv.py.
|
Hi, Thanks for the PR, and sorry for low reactivity, I slowly trying to get back into GRP development. I had never heard about "submodule" until today, so I will need a bit of time to learn about that before validating your commit. GRP also uses two other projects that could be moved to submodules as well. |
|
Why not using python package instead of git submodule? https://pypi.org/project/gomill/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Gomill project is far ahead of what is present in GRP. And there are already two commits in GRP doubling the work in the original project further in its history. I thought it might be a good idea to keep Gomill as a submodule to easily update it in GRP. The size difference is only 1M.
For a release, the README.txt with licence has to be moved or copied from gomill/gomill_setup to gomill/gomill and all the rest can be removed including the dot files.
Submodules introduce a bit of turbulence into main repositories, so I advise to test in a separate clone.
A documentation update would have to be applied.