Merge pull request #151 from poap-xyz/github-run-lint

Run lint on Github workflow
poap-xyz · Nov 27, 2024 · 8d260e7 · 8d260e7
2 parents 728bd38 + d4f30fd
commit 8d260e7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/.github/workflows/run-tests.yml → .github/workflows/run_checks.yml b/.github/workflows/run-tests.yml → .github/workflows/run_checks.yml
@@ -1,4 +1,4 @@
-name: Run Tests
+name: Run checks
 
 on:
   pull_request:
@@ -25,5 +25,8 @@ jobs:
       - name: Build packages
         run: yarn build
 
+      - name: Run lint
+        run: yarn lint
+
       - name: Run tests
         run: yarn test
diff --git a/packages/moments/src/client/MomentsClient.ts b/packages/moments/src/client/MomentsClient.ts
@@ -127,6 +127,10 @@ export class MomentsClient {
       media.fileBinary,
       url,
       media.fileType,
+      // FIXME the given function could return a promise but
+      // - moments api provider doesn't expect a fouth argument
+      // - poap moments api accepts a function that does not returns a promise
+      // eslint-disable-next-line @typescript-eslint/no-misused-promises
       onFileUploadProgress,
     );
 

diff --git a/packages/utils/src/queries/filter.ts b/packages/utils/src/queries/filter.ts
@@ -57,6 +57,7 @@ export function createAddressFilter(
     : {};
 }
 
+// eslint-disable-next-line complexity
 export function createNotNullAddressFilter(
   key: string,
   filterZeroAddress = true,