Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 41 #46

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Feature/issue 41 #46

merged 3 commits into from
Jan 29, 2024

Conversation

sliu008
Copy link
Contributor

@sliu008 sliu008 commented Jan 25, 2024 •
edited
Loading

Description

  • Fix images that have missing pixels in the images. This is usually due to the resolution being too high and theres not enough data to fill in the image completely

Overview of work done

  • Added functions to search through 2d grid points where there is filled in surrounding pixels and fill in that empty grid point with one of the values around that grid point

Overview of verification done

  • Tested on ascat collection to see there are smoother images produced

Original
ascat_20211115_071200_metopa_78218_eps_o_250_3202_ovw l2 nc wind_dir

New
ascat_20211115_071200_metopa_78218_eps_o_250_3202_ovw l2 nc wind_dir

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@sliu008 sliu008 requested a review from jamesfwood January 25, 2024 21:15
@sliu008 sliu008 marked this pull request as ready for review January 25, 2024 21:41
jamesfwood
jamesfwood approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@jamesfwood jamesfwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@sliu008 sliu008 merged commit c142c2a into develop Jan 29, 2024
3 checks passed
@jamesfwood jamesfwood deleted the feature/issue-41 branch January 4, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesfwood jamesfwood jamesfwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sliu008 @jamesfwood