Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Editor Form Validation #7369

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Block Editor Form Validation #7369

wants to merge 12 commits into from

Commits on Oct 14, 2024

  1. Create useBlockEditor hook 

    This hook will override the WP Editor savePost action just like ACF (for the time being) until a stable PreSavePost hook becomes available. I've already added todo tags into the code as a reminder.
Code is based on ACF: https://github.com/AdvancedCustomFields/acf/blob/6.3.8/assets/build/js/acf-input.js#L11285
    @JoryHogeveen
    JoryHogeveen committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    55fa52b View commit details
    Browse the repository at this point in the history

  2. Implement useBlockEditor as an effect to validation message changes

    @JoryHogeveen
    JoryHogeveen committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a6b8791 View commit details
    Browse the repository at this point in the history

  3. Fix valid status

    @JoryHogeveen
    JoryHogeveen committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    14f4da4 View commit details
    Browse the repository at this point in the history

  4. Use hook on init to properly set global vars 

    At this point `wp.data.dispatch('core/editor')` is available React is not rendered yet so we can properly override the savePost function.
    @JoryHogeveen
    JoryHogeveen committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    17610dd View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Auto rebuild assets

    @JoryHogeveen @github-actions
    JoryHogeveen authored and github-actions[bot] committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e43afda View commit details
    Browse the repository at this point in the history

  2. Do not return false and validate messages

    @JoryHogeveen
    JoryHogeveen committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    50b12ad View commit details
    Browse the repository at this point in the history

  3. Use same var structure as elsewhere in the codebase

    @JoryHogeveen
    JoryHogeveen committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    b0848d9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/7343-form-validation' of https://github.com/pod… 

    …s-framework/pods into feature/7343-form-validation
    @JoryHogeveen
    JoryHogeveen committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9428792 View commit details
    Browse the repository at this point in the history

  5. Check if block editor is loaded.

    @JoryHogeveen
    JoryHogeveen committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1203826 View commit details
    Browse the repository at this point in the history

  6. Auto rebuild assets

    @JoryHogeveen @github-actions
    JoryHogeveen authored and github-actions[bot] committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1b2ddae View commit details
    Browse the repository at this point in the history

  7. Add meetsConditionalLogic as a hook dependency 

    Signed-off-by: Jory Hogeveen <JoryHogeveen@users.noreply.github.com>
    @JoryHogeveen
    JoryHogeveen authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d8a0abe View commit details
    Browse the repository at this point in the history

  8. Auto rebuild assets

    @JoryHogeveen @github-actions
    JoryHogeveen authored and github-actions[bot] committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    60f9a41 View commit details
    Browse the repository at this point in the history