Update examples to use default main actor #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
commented
Oct 8, 2025
| } | ||
|
|
||
| enum Section: Hashable { | ||
| nonisolated enum Section: Hashable { |
There was a problem hiding this comment.
This is actually unrelated to our library. It's required just to work with UICollectionViewDiffableDataSource in default main actor isolation mode.
stephencelis
reviewed
Oct 8, 2025
mbrandonw
commented
Oct 8, 2025
|
|
||
| extension DependencyValues { | ||
| var openSettings: @Sendable () async -> Void { | ||
| nonisolated var openSettings: @Sendable () async -> Void { |
There was a problem hiding this comment.
this is what is necessary to work with Dependencies in default main actor isolation mode.
mbrandonw
commented
Oct 8, 2025
| .denied | ||
| } | ||
| var startTask: | ||
| @Sendable (_ request: SFSpeechAudioBufferRecognitionRequest) async -> AsyncThrowingStream< |
There was a problem hiding this comment.
SFSpeechAudioBufferRecognitionRequest is not sendable and this is now complaining. but we really don't need to accept this value as an argument in this demo so I just got rid of it.
mbrandonw
commented
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we don't feel that most projects should be using default main actor isolation, it is the default for new projects in Xcode 26. As such we have converted our demo apps to use default main actor isolation so that one knows how to work around its quirks.