Skip to content

Conversation

stephencelis
Copy link
Member

We missed a couple.

Updated the note about reserved CloudKit fields to clarify that an exhaustive list has not been published by Apple.
@larryonoff
Copy link
Contributor

@stephencelis perhaps it would be beneficial to implement validation of reserved keyword use during SyncEngine initialization in Debug mode?

@stephencelis
Copy link
Member Author

@larryonoff We'd definitely be down for a PR on this. It's a nice-to-have but not something we're able to prioritize ourselves right now.

@larryonoff
Copy link
Contributor

@larryonoff We'd definitely be down for a PR on this. It's a nice-to-have but not something we're able to prioritize ourselves right now.

thanks! makes sense.

@stephencelis
Copy link
Member Author

@larryonoff If you end up tackling it let us know if you have any questions!

@larryonoff
Copy link
Contributor

@stephencelis I’m happy to help, but I’m don't have time yet. By the way, do you think we should validate it at initialization or when the SyncEngine starts? Should it happen using IssueReporting reportIssue?

@stephencelis
Copy link
Member Author

@larryonoff I think you could add it as a throwing failure to this method (called from the initializer):

fileprivate func validateSchema() throws {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants