-
Notifications
You must be signed in to change notification settings - Fork 33
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge remote-tracking branch 'pokt/main' into fix/zero-value-nonce
* pokt/main: [P2P] Integrate background router (#732) Update main README.md [Bug] Fix CI linter errors (#885) [Tooling] Block `IN_THIS_*` comments from passing CI (#889) [Utility] Update E2E feature path template doc (#870) [IBC] Add nil check on proof for membership and non-membership proof creation (#877) Added git diff state to devlog10 Devlog 10 (#872)
- Loading branch information
Showing
35 changed files
with
1,648 additions
and
322 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| name: golangci-lint | ||
| # Copied from https://github.com/golangci/golangci-lint-action | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, reopened, synchronize] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| env: | ||
| # Even though we can test against multiple versions, this one is considered a target version. | ||
| TARGET_GOLANG_VERSION: "1.19" | ||
| PROTOC_VERSION: "3.19.4" | ||
|
|
||
| jobs: | ||
| golangci: | ||
| name: lint | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: ${{ env.TARGET_GOLANG_VERSION }} | ||
| cache: false | ||
| - name: Install Protoc | ||
| uses: arduino/setup-protoc@v1 | ||
| with: | ||
| version: ${{ env.PROTOC_VERSION }} | ||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: install CI dependencies | ||
| run: make install_ci_deps | ||
| - name: generate protobufs, RPC server, RPC client and mocks | ||
| run: make protogen_clean && make protogen_local && make mockgen && make generate_rpc_openapi | ||
| - name: golangci-lint | ||
| uses: golangci/golangci-lint-action@v3 | ||
| with: | ||
| version: latest | ||
| args: --timeout=10m --build-tags=test | ||
| skip-cache: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| //nolint // it's not a Go code file | ||
| //go:build !codeanalysis | ||
| // +build !codeanalysis | ||
|
|
||
| // This file includes our custom linters. | ||
| // If you want to add/modify an existing linter, please check out ruleguard's documentation: https://github.com/quasilyte/go-ruleguard#documentation | ||
|
|
||
| package gorules | ||
|
|
||
| import ( | ||
| "github.com/quasilyte/go-ruleguard/dsl" | ||
| ) | ||
|
|
||
| // Blocks merge if IN_THIS_ comments are present | ||
| func BlockInThisCommitPRComment(m dsl.Matcher) { | ||
| m.MatchComment(`//.*IN_THIS_.*`). | ||
| Where(!m.File().Name.Matches(`Makefile`) && !m.File().Name.Matches(`blockers.go`)). | ||
| Report("'IN_THIS_' comments must be addressed before merging to main") | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| # Pocket V1 DevLog #10 <!-- omit in toc --> | ||
|
|
||
| **Date Published**: July 5th, 2023 | ||
|
|
||
| We have kept the goals and details in this document short, but feel free to reach out to @Olshansk in the [core-dev-chat](https://discord.com/channels/553741558869131266/986789914379186226) for additional details, links & resources. | ||
|
|
||
| ## Table of Contents <!-- omit in toc --> | ||
|
|
||
| - [Iteration 20 Goals \& Results](#iteration-20-goals--results) | ||
| - [V0](#v0) | ||
| - [M1: PoS](#m1-pos) | ||
| - [M2: DoS](#m2-dos) | ||
| - [M3: RoS](#m3-ros) | ||
| - [M7: IBC](#m7-ibc) | ||
| - [Contribute to V1 🧑💻](#contribute-to-v1-) | ||
| - [Links \& References](#links--references) | ||
| - [ScreenShots](#screenshots) | ||
| - [Iteration 19 - Completed](#iteration-19---completed) | ||
| - [Iteration 20 - Planned](#iteration-20---planned) | ||
|
|
||
| ## Iteration 20 Goals & Results | ||
|
|
||
| **Iterate Dates**: June 15th - June 30th, 2023 | ||
|
|
||
| 🔥 The team frikkin killed it 🔥 | ||
|
|
||
| ```bash | ||
| git diff 2074a1b0c27ec2c73168b02852cc6145b657c0af --stat | ||
| # 107 files changed, 9032 insertions(+), 10508 deletions(-) | ||
| ``` | ||
|
|
||
| Note that this exclude the work we did on infrastructure support, internal documentation, v0 work, SMT repo, collaboration with other projects and a lot more that happens behind the scenes! | ||
|
|
||
| ### V0 | ||
|
|
||
| - 🟢 **TestNet Rehearsal** | ||
|
|
||
| - 100% completeness of TestNet Rehearsal | ||
| - **Grade**: 10 / 10 | ||
| - Completed | ||
|
|
||
| - 🟢 **MainNet Rehearsal** | ||
| - Have 5% of MainNet run the latest beta (w/o protocol upgrade) | ||
| - **Grade**: 10 / 10 | ||
| - Completed and found some bugs along the way too when synching from scratch | ||
|
|
||
| ### M1: PoS | ||
|
|
||
| - 🔴 Consensus | ||
|
|
||
| - Attempt #1: Remove State Sync dependency on FSM | ||
| - Attempt #3: finish minimum viable state sync | ||
| - **Grade**: 1 / 10 | ||
| - Very little time left to work on this | ||
|
|
||
| - 🟢 Persistence | ||
|
|
||
| - MVP of the full commit & rollback DEMO | ||
| - **Grade**: 7 / 10 | ||
| - The test which was going to be the demo has fought me more than expected but good progress has been made, there’s a design document ready, and the test harness is there, the mocks and the submodule interactions have been the problem. | ||
|
|
||
| - 🟢 P2P | ||
| - Attempt #N: Finishing off and merging in everything related to gossip and background | ||
| - **Grade**: 8.5 / 10 | ||
|
|
||
| ### M2: DoS | ||
|
|
||
| - 🔴 **Primary focus: observability** | ||
| - Open question: need to identify issues w/ metric access | ||
| - Streamlining logging: Make structured logging system easily available to new devs w/ documentation part of LocalNet instructions | ||
| - Attach smaller tickets in a separate repo to V2 | ||
| - **Grade**: 0 / 10 | ||
| - Other infrastructure related maintenance issues took away time from being able to focus on observability | ||
|
|
||
| ### M3: RoS | ||
|
|
||
| - 🟢 **Trustless Relay** | ||
|
|
||
| - Session caching on the client | ||
| - Finish all the PRs in flight (review, merge in) | ||
| - Provide an E2E test that works, blocks CI if it breaks, documented and visible (DEMO) | ||
| - **Grade**: 8 / 10 | ||
|
|
||
| - 🟡 **Feature Flags** | ||
| - Scope out the work necessary and create an E2E Feature Path github ticket using the template we created | ||
| - **Grade**: 5 / 10 | ||
| - Research and design doc made good progress w/ support from bigBoss bus still a lot to do. | ||
|
|
||
| ### M7: IBC | ||
|
|
||
| - 🟢 **SMST** | ||
|
|
||
| - Get it reviewed & merged in | ||
| - Clean up the documentation & merge it in | ||
| - Visualizers: create a visualizer for the tree | ||
| - Present: Finish off the SMT presentation | ||
| - Stretch goal: potentially start storing trustless relays in it | ||
| - **Grade**: 8.5 / 10 | ||
| - SMST merged (wrapper around SMT option) | ||
| - Visualiser is accurate but not pretty could do with some more work | ||
| - Presentation went well but definietly could improve on some packed slides | ||
| - Need to work closer with @Arash Deshmeh to get it in prod with M3 | ||
|
|
||
| - 🟢 **ICS23** | ||
|
|
||
| - Put up the github ticket and PR for reivew to merge in the proof mechanisms | ||
| - Up to cosmos on ETA to review/merge | ||
| - **Grade**: 9 / 10 | ||
| - ICS23 merged in our repo using my fork of `cosmos/ics23` as a dependency | ||
| - My explanations on why the exclusion proof is needed can improve as others find it hard to understand | ||
| - Cosmos PR is ready to merge pending review (probably take a while) | ||
|
|
||
| - 🟡 **ICS24** | ||
|
|
||
| - Put up event logging for review; stretch goal is to merge | ||
| - **Grade**: 6 / 10 | ||
| - ICS-24 stores have made great progress | ||
| - Event logging unfortunately didnt make this fortnight | ||
| - Message onto/off of bus as transactions works well 👍🏻 | ||
|
|
||
| - 🟡 **Light client spike** | ||
| - Start knowing where to head with research | ||
| - **Grade**: 5 / 10 | ||
| - ICS-02 specced out well | ||
| - ICS-08 needs more work into its design | ||
| - Need to learn more about CosmWasm and WasmVM | ||
| - WIP document needs to be converted to ticket epic | ||
| - https://hackmd.io/0WVMarGpSIGqEyzvnygWpw | ||
|
|
||
| ## Contribute to V1 🧑💻 | ||
|
|
||
| ### Links & References | ||
|
|
||
| - [V1 Specifications](https://github.com/pokt-network/pocket-network-protocol) | ||
| - [V1 Repo](https://github.com/pokt-network/pocket) | ||
| - [V1 Wiki](https://github.com/pokt-network/pocket/wiki) | ||
| - [V1 Project Dashboard](https://github.com/pokt-network/pocket/projects?query=is%3Aopen) | ||
|
|
||
| ## ScreenShots | ||
|
|
||
| Please note that everything that was not `Done` in iteration19 is moving over to iteration20. | ||
|
|
||
| ### Iteration 19 - Completed | ||
|
|
||
|  | ||
|  | ||
|
|
||
| ### Iteration 20 - Planned | ||
|
|
||
| _tl;dr Aim to demo as much of the work from the previous iteration in action_ | ||
|
|
||
| ) | ||
|
|
||
| <!-- GITHUB_WIKI: devlog/2023_07_05 --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.