[Morse->Shannon Migration] state export/import - collect accounts #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
force-pushed
the
chore/migration/state-prep
branch
from
f648aa5 to
e35ca54
Compare
bryanchriswhite
changed the base branch from
scaffold/migration/morse-state
to
scaffold/migration-module
bryanchriswhite
force-pushed
the
chore/migration/state-prep
branch
from
12a072c to
900c66b
Compare
bryanchriswhite
commented
Jan 27, 2025
bryanchriswhite
force-pushed
the
chore/migration/state-prep
branch
2 times, most recently
from
3515058 to
20aa71d
Compare
bryanchriswhite
commented
Jan 27, 2025
bryanchriswhite
commented
Jan 27, 2025
9 tasks
bryanchriswhite
force-pushed
the
chore/migration/state-prep
branch
from
08b72b7 to
b19a003
Compare
bryanchriswhite
force-pushed
the
chore/migration/state-prep
branch
from
b19a003 to
890d5b5
Compare
9 tasks
Olshansk
added
on-chain
Olshansk
requested changes
Jan 29, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Olshansk
requested changes
Feb 6, 2025
There was a problem hiding this comment.
@bryanchriswhite Lots of good iteration.
I'm going to do a full E2E review of this once it's ready again.
I have a few asks
-
Please keep in mind that while you are aware of ongoing work in this PR and other PRs, it is not as easy for the reader/reviewer.
-
Wehere possible, please use bullet points for the docs rather than long sentences + paragraphs to reduce cognitive overload. Consider using the claude project.
-
Prior to the next round of reviews, lets:
- Close existing threads (if possible) due to the amount of cross-linging and outdateness
- Add
TODO_IN_THIS_PRdiscuss for ongoing tidscussions - Add TODO_MAINNET or TODO_MIGRATION for things you know are happening in future PRS
- If you think something needs an offline call/discussion for clearer alignment, lmk!
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
Olshansk
force-pushed
the
chore/migration/state-prep
branch
from
79f0c82 to
194fbc8
Compare
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 1039) |
github-actions
bot
added
devnet
push-image
Olshansk
approved these changes
Feb 11, 2025
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
poktrolld migrate collect-morse-accountscommand to convert Morse state export into aMorseAccountStatefor import into Shannon.Issue
Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsTesting
make docusaurus_start; only needed if you make doc changesmake go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist