Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAPI] Add Dockerfile to reliability generate the OpenAPI spec using ignite #1055

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

commoddity
Copy link
Contributor

@commoddity commoddity commented Feb 4, 2025

Summary

Adds a Dockerfile to build the outputted OpenAPI spec in a way that will work on all dev environments.

Issue

Type of change

Select one or more from the following:

Sanity Checklist

  • I have updated the GitHub Issue assignees, reviewers, labels, project, iteration and milestone
  • For docs, I have run make docusaurus_start
  • For code, I have run make go_develop_and_test and make test_e2e
  • For code, I have added the devnet-test-e2e label to run E2E tests in CI
  • For configurations, I have update the documentation
  • I added TODOs where applicable

@commoddity commoddity added the enhancement New feature or request label Feb 4, 2025
@commoddity commoddity requested a review from Olshansk February 4, 2025 22:20
@commoddity commoddity self-assigned this Feb 4, 2025
@Olshansk Olshansk added this to the Quality of Life milestone Feb 5, 2025
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@commoddity Please review the extra changes I made before merging but otherwise LGTM!

@Olshansk Olshansk changed the title feat: add dockerfile and build open api using it [OpenAPI] Add Dockerfile to reliability generate the OpenAPI spec using ignite Feb 5, 2025
Copy link
Contributor Author

@commoddity commoddity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@commoddity commoddity merged commit 9f19047 into main Feb 5, 2025
10 checks passed
@commoddity commoddity deleted the build-openapi-from-docker branch February 5, 2025 21:44
bryanchriswhite added a commit that referenced this pull request Feb 6, 2025
…_state' into issues/1034/feat/upload-state

* pokt/issues/1034/scaffold/morse_account_state:
  chore: review feedback improvements
  fix: linter error
  chore: review improvements
  chore: review feedback improvements
  [OpenAPI] Add `Dockerfile` to reliability generate the OpenAPI spec using `ignite` (#1055)
  [Migration] scaffold: module migration (#1032)
bryanchriswhite added a commit that referenced this pull request Feb 6, 2025
…d/morse_account_claim

* issues/1034/feat/upload-state:
  chore: review feedback improvements
  fix: linter error
  chore: review improvements
  chore: review feedback improvements
  [OpenAPI] Add `Dockerfile` to reliability generate the OpenAPI spec using `ignite` (#1055)
  [Migration] scaffold: module migration (#1032)
  [CI][Quick change] downgrade docker/login-action version (#1056)
  [Upgrades] v0.0.12 upgrade (#1043)
  Add a couple TODO_UPNEXT
bryanchriswhite added a commit that referenced this pull request Feb 10, 2025
…orse_account_state

* chore/migration/state-prep:
  fix: linter error
  fix: typo
  chore: review feedback
  chore: review feedback improvements
  [Documentation] Refactoring `dev.poktroll.com` during Beta TestNet #1 of N (#1058)
  fix: linter error
  chore: review improvements
  chore: review feedback improvements
  [OpenAPI] Add `Dockerfile` to reliability generate the OpenAPI spec using `ignite` (#1055)
  [Migration] scaffold: module migration (#1032)

# Conflicts:
#	api/poktroll/migration/morse_offchain.pulsar.go
#	proto/poktroll/migration/morse_offchain.proto
#	x/migration/types/morse_offchain.pb.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants